Ticket #1659 (closed enhancement: fixed)

Opened 5 years ago

Last modified 4 years ago

Darker color style

Reported by: gotar Owned by: slavazanko
Priority: trivial Milestone: 4.7.0
Component: mc-skin Version: 4.7.0-pre3
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

I've just finished translating my color style into new skin format. It's more suitable for working in dark rooms as it's not so bright as default one. Feel free to redistribute it.

Attachments

gotar.ini (1.2 KB) - added by gotar 5 years ago.
gotar.2.ini (1.3 KB) - added by gotar 5 years ago.
updated according to #1667
gotar.patch (259 bytes) - added by gotar 5 years ago.

Change History

Changed 5 years ago by gotar

comment:1 Changed 5 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted

Changed 5 years ago by gotar

updated according to #1667

comment:2 Changed 5 years ago by slavazanko

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Milestone changed from 4.7 to 4.7.0-pre4

comment:3 Changed 5 years ago by slavazanko

  • Status changed from testing to closed

Changed 5 years ago by gotar

comment:4 Changed 5 years ago by gotar

  • Status changed from closed to reopened
  • Resolution fixed deleted

Attached patch against #1703 (commited changes in this skin were obviously not checked...). And I'd like to point out #1670.

comment:5 Changed 5 years ago by slavazanko

  • Milestone changed from 4.7.0-pre4 to 4.7

comment:6 Changed 5 years ago by slavazanko

  • Status changed from reopened to accepted

From patch:

+hotkey=lightgray.black 

Why dot between colors?

comment:7 Changed 5 years ago by gotar

Must be just typo (and falls to defaults which is the same).

comment:8 Changed 5 years ago by slavazanko

  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.0

Created branch 1659_darker_color_style.

Initial changeset:6ab746a7e91963d2a1586b0b2977c31782fe2ae2

Review, please.

P.S. To all: I have idea... IMHO, need to remove all skins and keymaps from repo (exclude default skin and keymaps). All third-party files will plased into wiki-pages (as attachment).

Is this good idea?

comment:9 Changed 5 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:10 Changed 5 years ago by gotar

Changeset is fine.
As for additional skins and resources I don't think it is a good idea:

  1. no updates when new elements appear,
  2. no resources in tarballs (being also a distro packager I doubt anyone would fetch anything from wiki)

comment:11 Changed 5 years ago by andrew_b

  • Votes for changeset changed from slavazanko to slavazanko andrew_b
  • severity changed from on review to approved

comment:12 Changed 5 years ago by slavazanko

  • Votes for changeset changed from slavazanko andrew_b to commited-master
  • severity changed from approved to merged

comment:13 Changed 5 years ago by slavazanko

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:14 Changed 5 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.