FISH: timestamps don't show correctly

[slavazanko]

Test case:
1) Make FISH-connect to some host;
2) sort files by modification time;
3) will see older files (from previous year) as new files

For check, connect to same host and enter in command line:

ls -lt

Thanks for bugreport to Alexander Glyzov.

[IMDagger]

Fix for FISHFS files modification date

[IMDagger]

Because first part of FISH-ls script is Perl script. But localtime function returns dates like:
Fri Sep 18 10:40:28 2009
But in utilvfs.c is written: So both year and time is not allowed. fish_vfs_date.patch fixed write format of date.

[slavazanko]

Created branch 1450_fish_timestamps

Changesets:

• 9d5c128dd8ae8ae492b7e2e4d35a15f89b95a7e0: Ticket #1450: FISH: timestamps don't show correctly. Original patch from IMDagger
• 50e339a54bf49a1e424d32c8141957cb72c5d85c: Fix broken filenames and timestamps on really poor busybox devices. This is my patch for busybox-based devices (like my D-Link 500T).

Review, please.

[slavazanko]

merge changeset:a8a009126ea1fc3ed1d7a9cca0e3f3bbfbbcff4

[angel_il]

commit: 4fc08a729e1aefe22f1965e2536a88bdfcc0cf62 broke the FISH under my WL-500gP device (oleg's firmware)

all catalogs and files has ' n3' postfix, like this:

│/dev n3                  │ 
│/home n3                 │ 
│/lib n3                  │ 
│/mnt n3                  │ 
│/opt n3                  │ 
│/proc n3                 │ 
│/sbin n3                 │ 
│/tmp n3                  │ 
│/usr n3                  │ 
│/www n3                  │ 
│!etc                     │ 
│*linuxrc n3              │ 
│!var                     │ 
│ .version n3               

[angel_il]

/bin/ls -lan /
-rw-r--r--    1 0        0              10 Feb 28  2009 .version
drwxr-xr-x    1 0        0             360 Feb 28  2009 bin
drwxr-xr-x    1 0        0               0 Jan  1  1970 dev
lrwxrwxrwx    1 0        0               7 Feb 28  2009 etc -> tmp/etc
drwxr-xr-x    1 0        0               0 Feb 28  2009 home
drwxr-xr-x    1 0        0             164 Feb 28  2009 lib
-rwxr-xr-x    1 0        0            2032 Feb 28  2009 linuxrc
drwxr-xr-x    1 0        0               0 Feb 28  2009 mnt
drwxr-xr-x   17 0        0            4096 Mar 15  2009 opt
dr-xr-xr-x   34 0        0               0 Jan  1  2000 proc
drwxr-xr-x    1 0        0             522 Feb 28  2009 sbin
drwxrwxrwx    1 0        0               0 Jan  1  2000 tmp
drwxr-xr-x    1 0        0              71 Feb 28  2009 usr
lrwxrwxrwx    1 0        0               7 Feb 28  2009 var -> tmp/var
drwxr-xr-x    1 0        0            2229 Feb 28  2009 www

ls -lan /
total 15
drwxr-xr-x  1 0 0  360 2009-02-28 21:03 bin
drwxr-xr-x  1 0 0    0 1970-01-01 03:00 dev
lrwxrwxrwx  1 0 0    7 2009-02-28 21:04 etc -> tmp/etc
drwxr-xr-x  1 0 0    0 2009-02-28 21:04 home
drwxr-xr-x  1 0 0  164 2009-02-28 21:04 lib
-rwxr-xr-x  1 0 0 2032 2009-02-28 21:03 linuxrc
drwxr-xr-x  1 0 0    0 2009-02-28 21:04 mnt
drwxr-xr-x 17 0 0 4096 2009-03-15 00:09 opt
dr-xr-xr-x 34 0 0    0 2000-01-01 03:00 proc
drwxr-xr-x  1 0 0  522 2009-02-28 21:03 sbin
drwxrwxrwx  1 0 0    0 2000-01-01 03:00 tmp
drwxr-xr-x  1 0 0   71 2009-02-28 21:04 usr
lrwxrwxrwx  1 0 0    7 2009-02-28 21:04 var -> tmp/var
-rw-r--r--  1 0 0   10 2009-02-28 21:03 .version
drwxr-xr-x  1 0 0 2229 2009-02-28 21:03 www

[slavazanko]

Created branch 1450_fish_dir_load_fix

Initial changeset: a3ee5860bbf78cd4f65dd12eebba46397800b02d

Review

[slavazanko]

Merge changeset:e1a455945281807211b503f1424d22269cd25d0d

[lly]

Unfortunately, both 4.7.0.5 & 4.7.2 mc versions has broken FISH on embedded device with busybox 1.16.1 shell - all catalog & files looks like this:

┌<─ /#sh:admin@192.168.1.100/tmp ─.[^]>┐
│'n     Name      │ Size  │Modify time │
│/..              │UP--DIR│May  6 19:32│
│/."              │    240│Jan  1 03:00│
│/.."             │    170│May  5 00:00│
│/etc"            │    460│Jan  1 03:00│
│/local"          │    140│Jan  1  2000│
│/mnt"            │     40│Jan  1 03:00│
│/ppp"            │    100│Jan  1 03:00│
│/var"            │    180│Jan  1 03:00│
│ filter_rules"   │   1310│Jan  1 03:00│
│ nat_rules"      │    290│Jan  1 03:00│
│ resolv.conf"    │      0│Jan  1 03:00│
│ syslog.log"     │   5121│Jan  1 03:07│

i.e. with extra quote after name. Native ls output on device itself:

$ ls -lan /tmp
drwxrwxrwt    7 0        0              240 Jan  1 03:00 .
drwxr-xr-x   14 0        0              170 May  5  2010 ..
drwxr-xr-x    4 0        0              460 Jan  1 03:00 etc
-rw-r--r--    1 0        0             1310 Jan  1 03:00 filter_rules
drwxr-xr-x    5 0        0              140 Jan  1  2000 local
drwxr-xr-x    2 0        0               40 Jan  1 03:00 mnt
-rw-r--r--    1 0        0              290 Jan  1 03:00 nat_rules
drwxr-xr-x    2 0        0              100 Jan  1 03:00 ppp
-rw-r--r--    1 0        0                0 Jan  1 03:00 resolv.conf
-rw-r--r--    1 0        0             5954 Jan  1 03:15 syslog.log
drwxr-xr-x    9 0        0              180 Jan  1 03:00 var

[lly]

Sorry, forgot to mention that bug is observed on 4.7.0.1,4.7.0.2,4.7.0.3,4.7.0.4 too and absent in 4.7.0-pre4.

[angel_il]

branch: 1450_fish_fix
changeset: 0bbab2338ea02b29ffa2ee9655a6ea19634d527c

[lly]

Clarification - problem described in comment 16, appeared with recent busybox versions which supports "ls -Qlan" only.

[lly]

in 4.7.3 release my problem (see comment 16) was gone.