Ticket #3465: mc-3465-cleanup-missing_variable_declarations-warning-v2.patch

m4.include/mc-cflags.m4

@@ -66 +66 @@
     MC_CHECK_ONE_CFLAG([-Wmissing-field-initializers])
     MC_CHECK_ONE_CFLAG([-Wmissing-parameter-type])
     MC_CHECK_ONE_CFLAG([-Wmissing-prototypes])
+    MC_CHECK_ONE_CFLAG([-Wmissing-variable-declarations])
     MC_CHECK_ONE_CFLAG([-Wnested-externs])
     MC_CHECK_ONE_CFLAG([-Wno-long-long])
     MC_CHECK_ONE_CFLAG([-Wno-unreachable-code])

src/args.c

@@ -47 +47 @@
 /*** global variables ****************************************************************************/
 
 /* If true, show version info and exit */
-gboolean mc_args__show_version = FALSE;
+static gboolean mc_args__show_version = FALSE;
 
 /* If true, assume we are running on an xterm terminal */
 gboolean mc_args__force_xterm = FALSE;
@@ -192 +192 @@
     /* *INDENT-ON* */
 };
 
-GOptionGroup *terminal_group;
+static GOptionGroup *terminal_group;
 #define ARGS_TERM_OPTIONS 0
 static const GOptionEntry argument_terminal_table[] = {
     /* *INDENT-OFF* */
@@ -279 +279 @@
 
 #undef ARGS_TERM_OPTIONS
 
-GOptionGroup *color_group;
+static GOptionGroup *color_group;
 #define ARGS_COLOR_OPTIONS 0
 /* #define ARGS_COLOR_OPTIONS G_OPTION_FLAG_IN_MAIN */
 static const GOptionEntry argument_color_table[] = {

lib/tty/color-internal.c

@@ -54 +54 @@
 
 /*** file scope variables ************************************************************************/
 
-mc_tty_color_table_t const color_table[] = {
+static mc_tty_color_table_t const color_table[] = {
     {"black", COLOR_BLACK},
     {"gray", COLOR_BLACK + COLOR_INTENSITY},
     {"red", COLOR_RED},
@@ -81 +81 @@
     {NULL, 0}
 };
 
-mc_tty_color_table_t const attributes_table[] = {
+static mc_tty_color_table_t const attributes_table[] = {
     {"bold", A_BOLD},
 #ifdef A_ITALIC                 /* available since ncurses-5.9-20130831 / slang-pre2.3.0-107 */
     {"italic", A_ITALIC},

lib/vfs/interface.c

@@ -61 +61 @@
 
 extern GString *vfs_str_buffer;
 extern struct vfs_class *current_vfs;
-
+extern struct dirent *mc_readdir_result;
 /*** global variables ****************************************************************************/
 
 struct dirent *mc_readdir_result = NULL;

lib/vfs/vfs.c

@@ -60 +60 @@
 #include "gc.h"
 
 extern struct dirent *mc_readdir_result;
+extern GPtrArray *vfs__classes_list;
+extern GString *vfs_str_buffer;
+extern struct vfs_class *current_vfs;
 /*** global variables ****************************************************************************/
 
 GPtrArray *vfs__classes_list = NULL;
 
 GString *vfs_str_buffer = NULL;
-struct vfs_class *current_vfs = NULL;
 
+struct vfs_class *current_vfs = NULL;
 
 /*** file scope macro definitions ****************************************************************/
 

src/filemanager/boxes.c

@@ -93 +93 @@
 
 /*** file scope variables ************************************************************************/
 
-unsigned long configure_old_esc_mode_id, configure_time_out_id;
+static unsigned long configure_old_esc_mode_id, configure_time_out_id;
 
 /* Index in list_types[] for "user defined" */
 static const int panel_listing_user_idx = 3;
@@ -111 +111 @@
 static unsigned long ftpfs_always_use_proxy_id, ftpfs_proxy_host_id;
 #endif /* ENABLE_VFS && ENABLE_VFS_FTP */
 
-GPtrArray *skin_names;
-gchar *current_skin_name;
+static GPtrArray *skin_names;
+static gchar *current_skin_name;
 
 #ifdef ENABLE_BACKGROUND
 static WListbox *bg_list = NULL;

src/filemanager/filegui.c

@@ -243 +243 @@
 
 /*** file scope variables ************************************************************************/
 
-struct
+static struct
 {
     Widget *w;
     FileProgressStatus action;

src/filemanager/find.c

@@ -192 +192 @@
 /* *INDENT-ON* */
 
 static const size_t fbuts_num = G_N_ELEMENTS (fbuts);
-const size_t quit_button = 4;   /* index of "Quit" button */
+static const size_t quit_button = 4;   /* index of "Quit" button */
 
 static WListbox *find_list;     /* Listbox with the file list */
 

src/filemanager/layout.c

@@ -66 +66 @@
 #include "layout.h"
 #include "info.h"               /* The Info widget */
 
+extern int ok_to_refresh;
 /*** global variables ****************************************************************************/
 
 panels_layout_t panels_layout = {

src/setup.c

@@ -78 +78 @@
 
 #include "setup.h"
 
+extern int saving_setup;
 /*** global variables ****************************************************************************/
 
 char *global_profile_name;      /* mc.lib */

src/vfs/extfs/extfs.c

@@ -66 +66 @@
 
 /*** global variables ****************************************************************************/
 
-GArray *extfs_plugins = NULL;
+static GArray *extfs_plugins = NULL;
 
 /*** file scope macro definitions ****************************************************************/
 

src/vfs/sftpfs/config_parser.c

@@ -71 +71 @@
 /*** file scope variables ************************************************************************/
 
 /* *INDENT-OFF* */
-struct
+static struct
 {
     const char *pattern;
     mc_search_t *pattern_regexp;

src/editor/spell.c

@@ -63 +63 @@
 static struct AspellCanHaveError *(*mc_new_aspell_speller) (struct AspellConfig * config);
 static unsigned int (*mc_aspell_error_number) (const struct AspellCanHaveError * ths);
 static const char *(*mc_aspell_speller_error_message) (const struct AspellSpeller * ths);
-const struct AspellError *(*mc_aspell_speller_error) (const struct AspellSpeller * ths);
+static const struct AspellError *(*mc_aspell_speller_error) (const struct AspellSpeller * ths);
 
 static struct AspellSpeller *(*mc_to_aspell_speller) (struct AspellCanHaveError * obj);
 static int (*mc_aspell_speller_check) (struct AspellSpeller * ths, const char *word, int word_size);