Ticket #3434: mc-fix-cflags-check-with-clang.patch

File mc-fix-cflags-check-with-clang.patch, 947 bytes (added by and, 9 years ago)

  • m4.include/mc-cflags.m4 

    fix cflags check when using clang compiler

with clang invalid cflags usage result in exit 0, we expect exit 1

$ clang -c -Wmaybe-uninitialized conftest.c ; echo $?
warning: unknown warning option '-Wmaybe-uninitialized'; did you mean '-Wuninitialized'? [-Wunknown-warning-option]
1 warning generated.
0

solution with -Werror on cflags check

$ clang -c -Werror -Wmaybe-uninitialized conftest.c ; echo $?
error: unknown warning option '-Wmaybe-uninitialized'; did you mean '-Wuninitialized'? [-Werror,-Wunknown-warning-option]
1

(tested with clang 3.6)

Signed-off-by: Andreas Mohr <and@gmx.li>
    a b  
    1212  AC_MSG_CHECKING([whether ${CC} accepts $1]) 
    1313 
    1414  safe_CFLAGS=$CFLAGS 
    15   CFLAGS="$1" 
     15 
     16  case "$CC" in 
     17    clang*) 
     18      CFLAGS="-Werror $1" 
     19      ;; 
     20    *) 
     21      CFLAGS="$1" 
     22      ;; 
     23  esac 
    1624 
    1725  AC_COMPILE_IFELSE( 
    1826    [AC_LANG_PROGRAM([], [[return 0;]])],